[PATCH] D105985: Support GSYM in llvm-symbolizer.

[Simon Giesecke via Phabricator via llvm-commits]

simon.giesecke added a comment.

In D105985#2879253 <https://reviews.llvm.org/D105985#2879253>, @jhenderson wrote:

> I have zero experience with or knowledge about gsym, so I can't comment on the implementation details, but some higher-level comments:
>
> 1. Make sure to review the llvm-symbolizer documentation to see if there's anything there that needs adding/updating given this change (there may not be).

Sure, I'll check that.

> 2. Can you avoid using pre-canned binaries for the test input, by somehow generating the inputs on the fly? The existing pre-canned binaries in the llvm-symbolizer tests are already sub-optimal, in my opinion, as they are opaque and make testing less flexible.

The sym-gsymonly test is mostly a copy of the sym test, and the binary is just the stripped binary. These additional files don't need to be part of the repository, we could run `llvm-gsymutil --convert` and strip DWARF from it as part of the test.

If this should be migrated to remove the use of the canned binary entirely, I fear I am not knowledgable enough on the test infrastructure to do that.

This should probably have been stated in the test file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105985/new/

https://reviews.llvm.org/D105985