[PATCH] D106010: [SimplifyCFG] Rerun PHI deduplication after common code sinkinkg (PR51092)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM as a stopgap until we can decide what to do about additional CSE runs - cheers



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6735
 
   if (SinkCommon && Options.SinkCommonInsts)
+    if (SinkCommonCodeFromPredecessors(BB, DTU))
----------------
Add comment to explain why the early out?


================
Comment at: llvm/test/Transforms/PhaseOrdering/X86/earlycse-after-simplifycfg-two-entry-phi-node-folding.ll:7
 target triple = "x86_64-unknown-linux-gnu"
 
 define dso_local void @foo(i32* %in, i64 %lo, i64 %hi, i32 %ishi) #0 {
----------------
Please can you mention PR51092 in a comment here? It helps with quick triage without git log/blame trawling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106010/new/

https://reviews.llvm.org/D106010