[PATCH] D105968: [libunwind][CET] Support exception handling stack unwind in CET environment

xiongji90 via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 01:02:10 PDT 2021


xiongji90 added inline comments.


================
Comment at: libunwind/src/cet_unwind.h:28
+      else {                                                                   \
+        unsigned int iters = (x) / 255;                                        \
+        unsigned int rem = (x) % 255;                                          \
----------------
hjl.tools wrote:
> Why are / and % used here?  You pop 255 frames a time if numbers of frame > 255.
Removed unnecessary % and /.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105968/new/

https://reviews.llvm.org/D105968



More information about the llvm-commits mailing list