[PATCH] D106022: [lit] Add --xfail-not/LIT_XFAIL_NOT

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/docs/CommandGuide/lit.rst:270
+  ``LIT_XFAIL_NOT`` can also be used in place of this option.  The syntax is the
+  same as for ``--xfail`` and ``LIT_XFAIL``.  ``--xfail-not`` and
+  ``LIT_XFAIL_NOT`` always override all other ``XFAIL`` specifications,
----------------
References to options should be preceded with `:option:`, so that they're auto-linked to them. Take a look at e.g. some of the LLVM binutils for examples of its usage.


================
Comment at: llvm/docs/CommandGuide/lit.rst:272
+  ``LIT_XFAIL_NOT`` always override all other ``XFAIL`` specifications,
+  including an ``--xfail-not`` appearing later on the command line.  However,
+  the primary purpose is to suppress an ``XPASS`` result without modifying a
----------------
jdenny wrote:
> Sorry.  Will fix later.
I don't think you need the "However" bit of the last sentence (the rest of it is fine).


================
Comment at: llvm/utils/lit/tests/xfail-cl.py:13
 
+# Check that --xfail and LIT_XFAIL_NOT always have precedence.
+
----------------
?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106022/new/

https://reviews.llvm.org/D106022