[PATCH] D104432: [Attributor] Introduce AAPointerInfo

[Kuter Dinel via Phabricator via llvm-commits]

kuter accepted this revision.
kuter added a comment.
This revision is now accepted and ready to land.

LGTM as far as I can see. One small nit.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1336
+      ChangeStatus Changed;
+      if (ArgNo == 0) {
+        handleAccess(A, *MI, Ptr, nullptr, AccessKind::AK_WRITE, 0, Changed,
----------------
NIT
This depends on the argument position places of `MemIntrinsic` right.
the first one is always the destination and the second one is always the source ? 
It's kinda hard to see what's going on here.  Maybe some documentation would be great.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104432/new/

https://reviews.llvm.org/D104432