[PATCH] D106000: [NFC] X86: Annotate sibcall test

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/test/CodeGen/X86/sibcall.ll:9
 define dso_local void @t1(i32 %x) nounwind ssp {
+  tail call void @foo() nounwind
+  ret void
----------------
urnathan wrote:
> xbolva00 wrote:
> > Looks like it was not regenerated by update_llc_test_checks.py.
> That seems to be breaking the llvm ir apart around the lit patterns, making them hard to read.  What is the rationale for doing that?
Well.. it is a common standard in the LLVM project to make test updates easier for future development.

“Hard to read” is subjective, LLVM devs are familiar with this style of tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106000/new/

https://reviews.llvm.org/D106000