[PATCH] D105953: [MachineVerifier] Diagnose invalid INSERT_SUBREGs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 14 13:16:02 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:1786
+  case TargetOpcode::INSERT_SUBREG: {
+    const auto &TRI = MRI->getTargetRegisterInfo();
+    unsigned InsertedSize =
----------------
This is already TRI tin the verifier class


================
Comment at: llvm/test/MachineVerifier/test_insert_subreg.mir:1
+#RUN: not --crash llc -march=aarch64 -o - -global-isel -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
+# REQUIRES: aarch64-registered-target
----------------
-global-isel doesn't do anything with -run-pass


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105953/new/

https://reviews.llvm.org/D105953



More information about the llvm-commits mailing list