[PATCH] D105877: [Coroutines] Run coroutine passes by default

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

I think I'd slightly prefer a separate option rather than always running coroutine passes, but we already have OpenMP passes in the pipeline that always run, so this isn't any worse than that, so this seems fine



================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:2194
+  // caused by multithreaded coroutines
+  if ((InsertLifetime || Caller->isPresplitCoroutine()) &&
+      !IFI.StaticAllocas.empty()) {
----------------
ChuanqiXu wrote:
> lxfind wrote:
> > What's the context of this change? Doesn't seem to be related to this diff?
> Related contexts are at  line 1934 in PassBuilder.cpp. The pass builder would set InsertLifetimeIntrinsics to be true for AlwaysInliner even at O0 as the comments tells.
> 
> This change would make sure the AlwaysInliner to insert lifetimes at O0. It wouldn't affect inliner since inliner wouldn't run at O0. And normal inliner would insert lifetime all the time.
can you add this to the description? or even better, split it out into a different patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105877/new/

https://reviews.llvm.org/D105877