[PATCH] D106000: [NFC] X86: Annotate sibcall test

Nathan Sidwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 14 10:11:37 PDT 2021


urnathan created this revision.
urnathan added reviewers: efriedma, haberman, mizvekov.
Herald added a subscriber: pengfei.
urnathan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This annotates the current X86/sibcall.ll testcase about why a particular test can be tailcalled or not tailcalled.  I've added QOI markers to ones that could be tailcalled, if we were sufficiently smart (eg as pr51000 points out).  I also reordered the lit check lines so they are no longer between the function header and the body -- that makes it much easier to follow the llvm ir.

I figured this would be a good start before progressing with D105807 <https://reviews.llvm.org/D105807> (thanks for the feedback on that)


https://reviews.llvm.org/D106000

Files:
  llvm/test/CodeGen/X86/sibcall.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106000.358655.patch
Type: text/x-patch
Size: 17502 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210714/50a3995b/attachment.bin>


More information about the llvm-commits mailing list