[PATCH] D105023: [AIX][XCOFF][Bug-Fixed] parse the parameter type of the traceback table.

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA added inline comments.


================
Comment at: llvm/lib/BinaryFormat/XCOFF.cpp:120-126
+  // In the function PPCFunctionInfo::getParmsType(),when there is no vector
+  // parameter, the 31th bit of ParmsType is always zero even if it indicates a
+  // floating point parameter. it lose the information of parameter type. There
+  // are only 8 GPRs used for parameters pass, the floating parameters
+  // also occupy GPRs if there is, so the 31th bit never be a fixed parameter.
+  // At the same time, we do not know the zero of 31th bit indicates a float
+  // or double parameter type here, So we ignore the 31th bit.
----------------



================
Comment at: llvm/test/CodeGen/PowerPC/aix-emit-tracebacktable.ll:136
 
+define i32 @foo(i32 %i1, i32 %i2, i32 %i3, i32 %i4, i32 %i5, i32 %i6, i32 %i7, float %f1, float %f2, float %f3, float %f4, float %f5, float %f6, float %f7, float %f8, float %f9, float %f10, float %f11, float %f12, float %f13, float %f14, i32 %i8) #0 {
+entry:
----------------



================
Comment at: llvm/test/CodeGen/PowerPC/aix-emit-tracebacktable.ll:252
+; COMMON-NEXT:  .byte   "foo"                           # Function Name
+; COMMON-NEXT:                                        # -- End functio
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105023/new/

https://reviews.llvm.org/D105023