[PATCH] D105020: [SLP]Improve graph reordering.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev marked an inline comment as done.
ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3068
+    return;
+  SmallVector<int> AvailableIndices(MaskedIndices.size());
+  unsigned Cnt = 0;
----------------
RKSimon wrote:
> Default value?
It is initialized with zeroes by default.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4265
   }
+  InstructionCost CommonCost = 0;
+  SmallVector<int> Mask;
----------------
RKSimon wrote:
> Is it worth doing the CommonCost -> ReuseShuffleCost refactor as a NFC pre-commit to simplify this patch?
Will check.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6106
+      SmallVector<int> Mask(Sz);
+      for (unsigned I = 0; I < Sz; ++I) {
+        unsigned Idx = I;
----------------
RKSimon wrote:
> A lot of this is just a refactor cleanup that looks like a NFC that could be done as a pre-commit to simplify the patch?
Yes, will precommit some of these changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105020/new/

https://reviews.llvm.org/D105020