[PATCH] D105528: [RuntimeDyldChecker] Support offset in decode_operand expr

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 14 04:47:42 PDT 2021


StephenFan added a comment.

In D105528#2864094 <https://reviews.llvm.org/D105528#2864094>, @lhames wrote:

> Side note: Some comparisons may be easier to express with the bit-slicing operator. E.g. this example from MachO_arm64_relocations.s:

Thanks, lhames! Bit-slicing looks like a great idea! I will change it.

>   # jitlink-check: decode_operand(test_local_call, 0)[25:0] = (named_func - test_local_call)[27:2]
>           .globl  test_local_call
>           .p2align  2
>   test_local_call:
>           bl   named_func
>
> Please address Jessica's feedback, but otherwise LGTM. Thanks Stephen!

Ok! I will!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105528/new/

https://reviews.llvm.org/D105528



More information about the llvm-commits mailing list