[PATCH] D100486: [COST]Improve cost model for shuffles in SLP.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 14 02:36:50 PDT 2021


RKSimon added a comment.

Thanks for looking at this - this is well overdue!



================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:1192
+        // Try to perform better estimation of the permutation.
+        // 1. Split the source/destination vectors into real registers.
+        // 2. Do the mask analysis to identify which real registers are
----------------
We already have something similar in DAGTypeLegalizer::SplitVecRes_VECTOR_SHUFFLE - do you think we could have a single version of the code some place? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100486/new/

https://reviews.llvm.org/D100486



More information about the llvm-commits mailing list