[PATCH] D73820: [llvm-strip][WebAssembly] Support strip flags

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/wasm/basic-only-section.test:21
+
+
+## Test that only-section + keep-section keeps both sections
----------------
dschuff wrote:
> jhenderson wrote:
> > Nit: we don't need all these extra blank lines: the `##` comment markers act as a good way of dividing up the test cases.
> Even with the ## markers, I still find it much more readable with a single blank line (although I agree that more than one isn't necessary).
Yes, single line is fine. Sorry if that wasn't clear (2+ lines is where I complain :) )

I tend to use the following pattern:

```
## Top-level test file comment.

## Test-case comment.
# RUN: <test case1> command
# RUN: <test case1> command2

# CHECK1: ...
# CHECK1: ...

<YAML>

## Test case 2 comment.
# ...
```


================
Comment at: llvm/test/tools/llvm-objcopy/wasm/only-keep-debug.test:12
+# CHECK:      Sections:
+# CHECK:   - Type: CUSTOM
+# CHECK-NEXT:     Name: .debug_info
----------------
Spacing looks off on this line?


================
Comment at: llvm/test/tools/llvm-objcopy/wasm/strip-all.test:7
+
+# CHECK: Sections:
+# CHECK-NEXT: - Type: TYPE
----------------
Spacing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73820/new/

https://reviews.llvm.org/D73820