[PATCH] D105866: [lld-macho] Use intermediate arrays to store opcodes

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 13 23:20:27 PDT 2021


int3 added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:395
     std::vector<BindingEntry> &bindings = p.second;
-    llvm::sort(bindings, [](const BindingEntry &a, const BindingEntry &b) {
-      return a.target.getVA() < b.target.getVA();
----------------
thevinster wrote:
> @int3 - `sortBindings` already sorts the bindings. Is there any reason to have to re-sort again? 
nope, it's leftover code from before I added sortBindings. good catch :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105866/new/

https://reviews.llvm.org/D105866



More information about the llvm-commits mailing list