[PATCH] D105248: [CSSPGO] Do not import pseudo probe desc in thinLTO

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 13 17:30:14 PDT 2021


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

> It appeared due to a glitch of our internal thinlto comdat deduplication change. Only part of the duplicated comdat groups were removed. llvm-profgen can tolerate that by taking only the last duplicate.

I think it'd be good to track it down why that happens - the expectation is to have identical probe_desc before/after this change. Though this change lgtm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105248/new/

https://reviews.llvm.org/D105248



More information about the llvm-commits mailing list