[PATCH] D105720: [AsmParser] Add support to LOCAL directive.

Tue Jul 13 17:22:53 PDT 2021

jcai19 added a comment.

In D105720#2875813 <https://reviews.llvm.org/D105720#2875813>, @MaskRay wrote:

> In D105720#2875779 <https://reviews.llvm.org/D105720#2875779>, @jcai19 wrote:
>
>> Yes, the reported case should be fixed by the proposed workaround but sometimes it may be more difficult to find a workaround such as in the the test cases. While this might not be common, PR#45051 shows there still could be real-work use cases of this directive, and I think we should try to support it especially when it does not introduce significant change to the existing code.
>
> The PR doesn't list a use case. This could be an obscure feature which probably no code uses.
> (There are now ~80 lines so I am reluctant on accepting that this is insignificant amount of code.)

RP#4505  stated this issue happened while building risc-v kernel with IAS so I assume it was a real-world usage. @nickdesaulniers is there an associated CBL link with more information? Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105720/new/

https://reviews.llvm.org/D105720