[PATCH] D101109: [SLP]Improve multinode analysis.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:1026
+      if (match(V2, m_ExtractElt(m_Value(EV), m_ConstantInt(Ex2Idx))) &&
+          match(V1, m_ExtractElt(m_Deferred(EV), m_ConstantInt(Ex1Idx)))) {
+        int Idx1 = Ex1Idx->getZExtValue();
----------------
Should this be m_Deferred or m_Specific? I thought m_Deferred was only necessary in the same match call?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:1031
+        // The distance is too large - still may be profitable to use
+        // shuffles.
+        if (std::abs(Dist) > NumLanes / 2)
----------------
Can this be a single line comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101109/new/

https://reviews.llvm.org/D101109