[PATCH] D105711: [OpaquePtr][Inline] Use byval type instead of pointee type

Tue Jul 13 10:28:25 PDT 2021

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

As per ( https://reviews.llvm.org/D105710#2874527 ) I still think there's room for valuable testing at this stage in the opaque pointer work.

Partly I think it's a matter of changing the approach from source based to test based - eg: running some chunk of the test suite with opaque pointers forced on, watching what tests fail, pick one, add a run line to force opaque pointers on, fixing the code until it passes. Rather than finding getElementPointer calls and changing them directly based on source inspection & existing regression testing only.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105711/new/

https://reviews.llvm.org/D105711