[PATCH] D105874: [flang][OpenMP] Add semantic check for reduction clause in taskloop simd construct

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

> The reason why it is not checked in `DirectiveStructureChecker` is the clause `OMPC_Reduction` is defined inside `OMP_TaskLoopSimd` in `llvm/include/llvm/Frontend/OpenMP/OMP.td`.
> I also noticed that there is no this restriction in openmp-5.0 specification.

I think this is going against the generic directive checker. If the clause is set as allowed in the `OMP.td` file it should be allowed. Since the file is shared with clang the semantic should be done on version 5.0 or 5.1.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105874/new/

https://reviews.llvm.org/D105874