[PATCH] D105889: [AArch64][SVE] Break false dependencies for inactive lanes of unary operations

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 13 06:13:54 PDT 2021


peterwaller-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:538
+    assert(DOPRegIsUnique && "The destructive operand should be unique");
+#endif
+    PRFX = BuildMI(MBB, MBBI, MI.getDebugLoc(), TII->get(MovPrfx))
----------------
Nit: Asserts are only present if not NDEBUG anyway, so the ifndef seems superfluous (I guess, delete it from the nearby ones since we're here?)

See https://en.cppreference.com/w/cpp/error/assert


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105889/new/

https://reviews.llvm.org/D105889



More information about the llvm-commits mailing list