[PATCH] D105874: [flang][OpenMP] Add semantic check for reduction clause in taskloop simd construct

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan requested changes to this revision.
kiranchandramohan added a comment.
This revision now requires changes to proceed.

Thanks, @peixin for this patch. Also great to see you here.

The recommendation is to provide the full context when submitting patches. I think if you use arcanist, this happens by default. If you use the web interface then there are some recommended commands to use to get the full context. Please see the following links.
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Also, could you point me to the place in the standard where this restriction is specified?



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:1035
+      context_.Say(clause->source,
+          "Unexpected clause specified for !$OMP taskloop simd"_err_en_US);
+    }
----------------
I think would be better to say that reduction is not expected for taskloop simd? Or is this a common pattern that we have in semantic errors?

I think we capitalize the name of constructs when we report errors. Please check other errors and capitalize if needed.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105874/new/

https://reviews.llvm.org/D105874