[PATCH] D105885: Enable Flang by default in the test-release.sh script

Mats Petersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 13 04:40:51 PDT 2021


Leporacanthicus added inline comments.


================
Comment at: llvm/utils/release/test-release.sh:175
         -no-mlir )
             do_mlir="no"
             ;;
----------------
rovka wrote:
> Minor nitpick: Should we error out if people explicitly pass -no-mlir but not -no-flang?
Or like "libs" which only looks at the other libs if the overall libs are enabled, so flang would go inside the mlir part. 

Not sure which is more natural. You almost certainly don't want flang if you have said no to MLIR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105885/new/

https://reviews.llvm.org/D105885



More information about the llvm-commits mailing list