[PATCH] D105570: [AArch64][SME] Add matrix register definitions and parsing support

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3008
+
+  MatrixKind Kind = StringSwitch<MatrixKind>(RowOrColumn)
+                        .Case("h", MatrixKind::Row)
----------------
c-rhodes wrote:
> david-arm wrote:
> > It looks like if I write assembly like this:
> > 
> >   addha za0p.d
> > 
> > then we'll treat this as a matrix tile. Do we have any tests that show us treating this type of register as an error?
> > It looks like if I write assembly like this:
> > 
> >   addha za0p.d
> > 
> > then we'll treat this as a matrix tile. Do we have any tests that show us treating this type of register as an error?
> 
> Same as above, that's not a valid reg name so it shouldn't match.
Is it possible to have at least one negative test case for this to show we print an error?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105570/new/

https://reviews.llvm.org/D105570