[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

Tue Jul 13 02:47:35 PDT 2021

luismarques added inline comments.

================
Comment at: llvm/test/CodeGen/RISCV/rvv/vfredusum-rv32.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv32 -mattr=+experimental-v,+d,+experimental-zfh -verify-machineinstrs \
----------------
frasercrmck wrote:
> Just to check - was this renaming done with `git mv`? Phabricator suggests that `vfredsum-rv32.ll` was deleted and this was added, which would be worse for the git history. It might be a phabricator quirk, though.
AFAIK `git mv` doesn't do anything in particular to track renames. File renames are automatically detected based on the added and removed content, which means that if there are also changes to the content that detection might fail, and here the instruction renames did cause a lot of changes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105690/new/

https://reviews.llvm.org/D105690