[PATCH] D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable.

Esme Yi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 13 01:29:59 PDT 2021


Esme added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/XCOFF/string-table.yaml:30-31
+  MagicNumber: 0x1DF
+Symbols:
+  - Name: asymname
----------------
jhenderson wrote:
> I don't think you need any symbols here to ensure an empty string table.
The absence of any symbols means that there is no string table, but the case tries to display an empty string table, which has no string data but the length field.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105522/new/

https://reviews.llvm.org/D105522



More information about the llvm-commits mailing list