[PATCH] D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/XCOFF/string-table.yaml:1
+## Test that the string table works well for storing symbol names.
+
----------------
These two test cases should be part of the llvm-readobj string table printing test, not here: you're testing llvm-readobj (including the XCOFFObjectFile code, via llvm-readobj), not yaml2obj.

Update the comments accordingly too.


================
Comment at: llvm/test/tools/yaml2obj/XCOFF/string-table.yaml:30-31
+  MagicNumber: 0x1DF
+Symbols:
+  - Name: asymname
----------------
I don't think you need any symbols here to ensure an empty string table.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105522/new/

https://reviews.llvm.org/D105522