[PATCH] D105831: [DebugInfo] Fix incorrect handling of debug values with duplicate location operands

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Basically LGTM.



================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1736
     SmallVector<Value *, 4> AdditionalValues;
-    DIExpression *SalvagedExpr = salvageDebugInfoImpl(
-        I, DII->getExpression(), StackValue, LocNo, AdditionalValues);
-
+    DIExpression *SalvagedExpr = DII->getExpression();
+    auto LocItr = find(DIILocation, &I);
----------------
Can we add a comment here by explaining what is the intention of the code below?


================
Comment at: llvm/test/CodeGen/AArch64/stack-tagging-dbg.ll:41
 !10 = !DILocation(line: 1, column: 2, scope: !3)
+!16 = !DILocalVariable(name: "y", scope: !3, file: !1, line: 4, type: !7)
----------------
nit: This is unused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105831/new/

https://reviews.llvm.org/D105831