[PATCH] D104569: [SimplifyCFG] Fix SimplifyBranchOnICmpChain to be undef/poison safe.

Hyeongyu Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 12 23:40:38 PDT 2021


hyeongyukim added a comment.

In D104569#2871466 <https://reviews.llvm.org/D104569#2871466>, @nikic wrote:

> LGTM. Looks like most of the remaining diffs are covered by D105344 <https://reviews.llvm.org/D105344>. The one in libclamav_regex_regcomp.c was a bit too large to understand at a glance, but it mostly looks like code movement.

I forgot to mention that D105344 <https://reviews.llvm.org/D105344> changed the patch's assembly.
I should have added more details, and thank you for writing it down for me.
Next time, I'll write it down in more detail so it's easier to review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104569/new/

https://reviews.llvm.org/D104569



More information about the llvm-commits mailing list