[PATCH] D105861: [llvm-exegesis] Rework cmake variables around LIBPFM checking.
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 12 23:19:07 PDT 2021
courbet added inline comments.
================
Comment at: llvm/cmake/modules/FindLibpfm.cmake:18
+ # libpfm versions, we have seen header-not-found errors
+ # while building, even though check_include_file() succeeded.
+ CHECK_CXX_SOURCE_COMPILES("
----------------
I just looked at the code for `check_include_file`[1]: They are using `#include <>` and not `#include ""` - can we try that before giving up ? Because there should really be no difference between CHECK_CXX_SOURCE_COMPILES and this.
[1] https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/CheckIncludeFile.c.in
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105861/new/
https://reviews.llvm.org/D105861
More information about the llvm-commits
mailing list