[PATCH] D105216: [ScalarEvolution] Fix overflow in computeBECount.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

> but I *strongly* request you look for ways to factor the code so that the reasoning is modular

I really don't see any way to unify the two different proof strategies.  The proofs are trying to reason about overflow on completely different operations.

> If we can split this into two or more patches, that would be my strong preference.

I can split off the introduction of getUDivCeilSCEV() into a separate patch, and I can introduce the new `isLoopEntryGuardedByCond(L, CondGT, Start, StartMinusStride)` check in a separate patch.  I'm not sure the result is easier to review, but I guess it would make it easier to figure out regressions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105216/new/

https://reviews.llvm.org/D105216