[PATCH] D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU.

Mon Jul 12 18:20:07 PDT 2021

holland11 added a comment.

In D104730#2872586 <https://reviews.llvm.org/D104730#2872586>, @tstellar wrote:

> @holland11 Did you run make check ?  The reason I had to update llvm/tools/llvm-mca/CMakeLists.txt was so that the tests pass (without it all invocations of llvm-mca failed with the 'multiple registered command line options' error.
>
> As for a fix, you can export symbols by adding the  LLVM_EXTERNAL_VISIBILITY to the function definition, but I don't know if exporting random symbols is necessarily a good idea if it's only needed for an internal tool. Is it possible to rewrite this patch to not use the symbols?  Or maybe can we put these symbols into their own static library?  We've run into this problem before with some unittests that reference target symbols,  so having some kind of static library solution for this would be generally useful.

Ah yeah I was just in the process of trying to fix the 'multiple registered command line options' error. Was hoping it was related to WSL so I was rebuilding within a ubuntu docker image to see if that fixed it. But I guess that's not going to fix it =/.

I'll have to think about this for a while longer. I appreciate all your help.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104730/new/

https://reviews.llvm.org/D104730