[PATCH] D105798: [docs]Examples to show implementation of GISel in AArch64

[PoojaYadav via Phabricator via llvm-commits]

pooja2299 added inline comments.


================
Comment at: llvm/docs/GlobalISel/AArch64examples.rst:2
+===============================
+GISel Implementation In AArch64 
+===============================
----------------
paquette wrote:
> Maybe more concise?
Okk. Seems precise to me.


================
Comment at: llvm/docs/GlobalISel/AArch64examples.rst:12
+
+Illustrating with examples to show the implementation of GlobalISel in AArch64.
+
----------------
paquette wrote:
> Can you expand on this a little?
> 
> - What kinds of examples does this documentation contain?
> - What can the reader expect to find in this documentation?
Yes, sure.


================
Comment at: llvm/docs/GlobalISel/AArch64examples.rst:22
+To lower incoming arguments.
+.. code-block:: none
+   bool AArch64CallLowering::lowerFormalArguments(
----------------
paquette wrote:
> I think that this code sample may rot over time. I think it would be better to describe, at a high level
> 
> - What lowering incoming arguments means
> - What must be done to lower incoming arguments
> 
> And then say "see `AArch64CallLowering::lowerFormalArguments`" for a sample.
okk


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105798/new/

https://reviews.llvm.org/D105798