[PATCH] D105798: [docs]Examples to show implementation of GISel in AArch64

PoojaYadav via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 12 18:10:05 PDT 2021


pooja2299 added a comment.

In D105798#2872479 <https://reviews.llvm.org/D105798#2872479>, @paquette wrote:

> I think that including entire code snippets will probably rot over time and potentially confuse readers.
>
> I think in general, it would be good to focus on high-level concepts so that we don't need to do as much work keeping this in sync with the code.
>
> Also, I'm not sure if we have documentation on terminology like "incoming arguments". If we do, I think it would be useful to link to the documentation for the terminology.

yes sure. Thanks for your feedback. This is the basic structure that i thought to made . I will be writing more descriptions and will add only the relevant code. I just wanted to get a quick feedback from you all , so that I get an idea what needs to be added and deleted. Your reviews are really helpful. Thanks! I will update soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105798/new/

https://reviews.llvm.org/D105798



More information about the llvm-commits mailing list