[PATCH] D105751: GlobalISel: Introduce GenericMachineInstr classes and derivatives for idiomatic LLVM RTTI.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/GenericMachineInstrs.h:61
+  /// Get the definition register of the loaded value.
+  Register getDstReg() const { return getOperand(0).getReg(); }
+
----------------
aemerson wrote:
> arsenm wrote:
> > Also getPtrReg? A get-single-mmo wrapper would be nice too
> Already provided in the base class `GLoadStore`.
> 
> I'll add a `getFirstMMO()` helper. We can also add more things like `isAtomic()` and `isVolatile()`.
Only one is legal, so no first


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105751/new/

https://reviews.llvm.org/D105751