[PATCH] D105720: [AsmParser] Add support to LOCAL directive.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

DenseSet<CachedHashStringRef> may be better than StringSet. The former doesn't need to duplicate the string.

Does `LOCAL` (https://bugs.llvm.org//show_bug.cgi?id=45051) have a use case?
As you mentioned, this can usually be replaced with local labels (`1:`)

---

If the feature turns out to be useful,

The implementation looks hackish to me. A proper implemention should make the `LOCAL` symbol similar to a macro argument.

I think the replacement should use a `.LL` symbol instead. For non-RISC-V the local symbols are not intended to be retained in the symbol table.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105720/new/

https://reviews.llvm.org/D105720