[PATCH] D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/wasm/SyntheticSections.cpp:126
+  llvm::Optional<StringRef> module;
+  llvm::Optional<StringRef> name;
+  if (auto *f = dyn_cast<FunctionSymbol>(sym)) {
----------------
Do these need to be optional?   Doesn't `getImportModuleAndName` unconditionally set them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105519/new/

https://reviews.llvm.org/D105519