[PATCH] D105784: [VPlan] Use vector version of GEP if result is used as vector.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 12 13:38:51 PDT 2021


fhahn added a comment.

In D105784#2870696 <https://reviews.llvm.org/D105784#2870696>, @david-arm wrote:

> Hi @fhahn, at first glance this change makes sense to me. Do you plan to run with this yourself or are you happy for me to push this solution further? The reason I ask is because we're hoping to get this important fix in as soon as possible for LNT. It looks with your change we may need a few explicit negative tests too to cover some of the logic in `IsUsedAsVector`. I also still have to fix the other remaining cases in D105199 <https://reviews.llvm.org/D105199>.

I plan to wrap up the patch tomorrow and also handle the other cases. If there is an issue blocking your LNT, it might be good to revert the commit that exposed/enabled the code that is causing the issue until it is resolved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105784/new/

https://reviews.llvm.org/D105784



More information about the llvm-commits mailing list