[PATCH] D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU.

[Patrick Holland via Phabricator via llvm-commits]

holland11 added a comment.

@tstellar You suggested in your original message to add the `DISABLE_LLVM_LINK_LLVM_DYLIB` to the `AMDGPUCustomBehaviour` cmake file. This would be a very reasonable solution since, in theory, it would let most of `mca` still benefit from shared libs. However, when you attempted the fix, you said that to get it to work, you had to also add that flag to the `llvm-mca` cmake file as well.

My work laptop is macOS, and my personal desktop is Win10, but Win10 has WSL (Windows Subsystem for Linux) which can be used for quite a bit of linux development without needing a VM. I wasn't sure if I was going to be able to recreate your original error using WSL, but I tried it and I got the error. (I cloned the llvm git repo, checked out this commit, then tried building with shared libs. This gave me the same error that you got.)

I then tried your original suggestion (only changing the AMDGPUCB cmake file) to confirm that it wasn't sufficient by itself. But this build succeeded for me?

This could definitely be related to the fact that I'm building in WSL and not pure linux, but if we can get it to work by only modifying the AMDGPUCB cmake file, that would be ideal.

Could you elaborate as to what the issue was when you tried your original fix and why you had to also change the llvm-mca cmake file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104730/new/

https://reviews.llvm.org/D104730