[PATCH] D105751: GlobalISel: Introduce GenericMachineInstr classes and derivatives for idiomatic LLVM RTTI.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/GenericMachineInstrs.h:61
+  /// Get the definition register of the loaded value.
+  Register getDstReg() const { return getOperand(0).getReg(); }
+
----------------
Also getPtrReg? A get-single-mmo wrapper would be nice too


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/GenericMachineInstrs.h:112
+  /// Get the stored value register.
+  Register getStoredReg() const { return getOperand(0).getReg(); }
+
----------------
Other places refer to this as the value reg


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105751/new/

https://reviews.llvm.org/D105751