[PATCH] D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 12 11:25:50 PDT 2021


kpn added a comment.

In D103490#2845377 <https://reviews.llvm.org/D103490#2845377>, @yusra.syeda wrote:

> In D103490#2825462 <https://reviews.llvm.org/D103490#2825462>, @kpn wrote:
>
>> Say, I can't find any file in the llvm repository named "GOFF*". They don't show up on Github, either, so I'm not sure what's going on. Where is the GOFF support in the LLVM tree currently? There's no "https://github.com/llvm/llvm-project/tree/main/llvm/lib/Object/GOFFObjectFile.cpp", for example.
>
> This patch is based off of https://reviews.llvm.org/D98437 which is where files you mentioned are added. https://reviews.llvm.org/D98437 cannot be committed until https://reviews.llvm.org/D88741 is committed. So these files are not in the llvm repository yet.

I don't think we should be getting so far ahead of ourselves. Get your prerequisites in tree first and then we can proceed with this patch. That's my take, anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103490/new/

https://reviews.llvm.org/D103490



More information about the llvm-commits mailing list