[PATCH] D105217: [LLD] Adding support for RELA for CG Profile.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 12 11:00:06 PDT 2021


MaskRay added inline comments.


================
Comment at: lld/test/ELF/cgprofile-rela.test:1
+## GNU tools strip/objcopy change REL to RELA. Testing the RELA path.
+# REQUIRES: x86
----------------
jhenderson wrote:
> I'd rewrite the comment like this:
> 
> "Under some circumstances, GNU tools strip/objcopy change REL to RELA. Test that LLD can handle call graph profile data relocated with RELA relocations."
You can attach https://sourceware.org/bugzilla/show_bug.cgi?id=28035 after "change REL to RELA"



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105217/new/

https://reviews.llvm.org/D105217



More information about the llvm-commits mailing list