[PATCH] D105780: [Attributes] Determine attribute properties from TableGen data

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

lgtm with some nits



================
Comment at: llvm/lib/IR/Attributes.cpp:504
+  unsigned Index = Kind - 1;
+  assert(Index < sizeof(AttrPropTable)/sizeof(AttrPropTable[0]) &&
+         "Invalid attribute kind");
----------------
formatting?


================
Comment at: llvm/lib/IR/Verifier.cpp:1872
+           "Attribute '" + RetAttr.getAsString() +
+               "' does not apply to function returns",
+           V);
----------------
if we're updating this message in a test, might as well make this "function return values"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105780/new/

https://reviews.llvm.org/D105780