[PATCH] D105806: [LV] Print remark when loop cannot be vectorized due to invalid costs.
Kerry McLaughlin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 12 10:16:39 PDT 2021
kmclaughlin accepted this revision.
kmclaughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me, I just have one question on the changes to selectVectorizationFactor
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:6141
+ reportVectorizationInfo(OutString, "InvalidCost", ORE, TheLoop,
+ InvalidCosts[0].first);
+ }
----------------
nit: should `InvalidCosts[0].first` be used as the location of the remark from reportVectorizationInfo, since there could be multiple instructions found in the loop with invalid costs?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105806/new/
https://reviews.llvm.org/D105806
More information about the llvm-commits
mailing list