[PATCH] D105824: [LV] Avoid scalable vectorization for loops containing alloca

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-alloca.ll:32
+entry:
+  %vla = alloca i32*, i64 %N, align 8
+  %cmp5 = icmp sgt i64 %N, 0
----------------
Do we need this `alloca` and the call to `@foo` at the bottom? I wonder if it may be simpler to pass a `i32** %vla` pointer to the function? I think the main thing we care about is the `alloca` in the loop I think?


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-alloca.ll:33
+  %vla = alloca i32*, i64 %N, align 8
+  %cmp5 = icmp sgt i64 %N, 0
+  br i1 %cmp5, label %for.body, label %for.end
----------------
nit: I think we can simplify the test here by just branching directly, i.e.

  br label %for.body

without the `icmp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105824/new/

https://reviews.llvm.org/D105824