[PATCH] D104662: [SCEVExpander] Prefer pointer expansion for overflow checks

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 12 08:46:30 PDT 2021


reames added a comment.

In D104662#2832601 <https://reviews.llvm.org/D104662#2832601>, @mkazantsev wrote:

> I don't think that increase of loop size may be justified by the fact that InstCombine will later clean it up. Loop passes may go in one loop pipeline, and passes like unswitch may be pessimized by this.

This comment doesn't make sense to me.  What increase in loop size are you referring to?   This change adjusts the type used for a generate test, nothing more.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104662/new/

https://reviews.llvm.org/D104662



More information about the llvm-commits mailing list