[PATCH] D104975: Implement P1949

[Corentin Jabot via Phabricator via llvm-commits]

cor3ntin added inline comments.


================
Comment at: clang/lib/Lex/UnicodeCharSets.h:229
+static const llvm::sys::UnicodeCharRange XIDContinueRanges[] = {
+    {0x0030, 0x0039},   {0x005F, 0x005F},   {0x00B7, 0x00B7},
+    {0x0300, 0x036F},   {0x0387, 0x0387},   {0x0483, 0x0487},
----------------
Quuxplusone wrote:
> Ah, here we go. `0x005F` is underscore. It should be in the XIDStart table instead.
These tables should match the Unicode spec exactly.
Unicode does not consider `_` to be valid at the start of an identifier.
C++ does, for obvious reasons, but these tables do not represent the C++ grammar, but the Unicode Spec.
(Hence the names, `XIDContinue`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104975/new/

https://reviews.llvm.org/D104975