[PATCH] D105743: [AIX] Emit version string in .file directive

[Jinsong Ji via Phabricator via llvm-commits]

jsji added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:316
+      OutStreamer->emitFileDirective(FileName, VerStr, "", "");
+    } else {
+      OutStreamer->emitFileDirective(FileName);
----------------
shchenz wrote:
> Don't need `{}` for the else block.
Thanks. I chose to add it because I think `omission of braces harm the readability and maintainability ` here, because the `if` body is too complex. So 

> Use braces for the `else` block to keep it uniform with the if block.


https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105743/new/

https://reviews.llvm.org/D105743