[PATCH] D105787: [WIP][AbstractAttributor] Fold function calls to `__kmpc_is_spmd_exec_mode` if possible

Shilei Tian via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 11 19:39:34 PDT 2021


tianshilei1992 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3431
+    : public StateWrapper<KernelInfoState, AbstractAttribute> {
+  using Base = StateWrapper<KernelInfoState, AbstractAttribute>;
+
----------------
jdoerfert wrote:
> Do we need/want a KernelInfoState here? Wouldn't a BooleanState suffice to do the tacking of valid/invalid and fixpoint. Plus the `  Optional<Constant *> SimplifiedValue;`.
Nope because we access `CallerKernelInfoAA.ReachingKernelEntries` directly in `foldIsSPMDExecMode`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105787/new/

https://reviews.llvm.org/D105787



More information about the llvm-commits mailing list