[PATCH] D105615: [llvm-exegesis] Fix compilation with old libpfm versions.

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 11 19:04:11 PDT 2021


oontvoo added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/X86/X86Counter.cpp:19-23
 #ifdef HAVE_LIBPFM
 #include "perfmon/perf_event.h"
 #include "perfmon/pfmlib.h"
 #include "perfmon/pfmlib_perf_event.h"
 #endif // HAVE_LIBPFM
----------------
I'm not sure why this block isn't enough to prevent the inclusion of all libpfm stuff.
(AFAIK, LIBPFM_HAS_FIELD_CYCLES signals a subset of features whereas HAVE_LIBPFM tells you if the library exsits)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105615/new/

https://reviews.llvm.org/D105615



More information about the llvm-commits mailing list